Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set domainCombiner from closest frame in result AccessControlContext #11664

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Set domainCombiner from closest frame in result AccessControlContext #11664

merged 1 commit into from
Jan 15, 2021

Conversation

JasonFengJ9
Copy link
Member

Set domainCombiner from closest frame in result AccessControlContext of j.s.AccessController.getContextHelper() if the activeDC is null.

This is part of fix #3051 lost when fixing #6492.
Note: #6492 has its own automated test which still passes with PR in a personal build (s390x_linux 8/11/15 sanity.functional). The test for this PR is jdk_security4 - test/jdk/sun/security/krb5/auto/HttpNegotiateServer.java.

closes #11268

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9
Set domainCombiner from closest frame in result AccessControlContext
ac37885 
Set domainCombiner from closest frame in result AccessControlContext of
j.s.AccessController.getContextHelper() if the activeDC is null.

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9
Copy link
Member Author

@pshipton could you please review?

This was referenced Jan 15, 2021
Merged
Closed
@pshipton
Copy link
Member

jenkins test sanity,extended,sanity.openjdk zlinux jdk8,jdk11

@pshipton
Copy link
Member

On jdk8, attempted jdk_security4 using adoptium/aqa-tests#2175, but the only test that ran (and failed) is sun/security/krb5/auto/ReplayCacheTestProc.java
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1417/console

Attempted jdk/test/sun/security/krb5/auto/HttpNegotiateServer.java directly, but it didn't run.
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1421/console

For jdk11, running jdk_security4 ran HttpNegotiateServer.java and passed.
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1421

@pshipton pshipton merged commit 5902d2e into eclipse-openj9:master Jan 15, 2021
@JasonFengJ9
Copy link
Member Author

JasonFengJ9 commented Jan 16, 2021 •
edited
Loading

On jdk8, attempted jdk_security4 using adoptium/aqa-tests#2175, but the only test that ran (and failed) is sun/security/krb5/auto/ReplayCacheTestProc.java
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1417/console
For jdk11, running jdk_security4 ran HttpNegotiateServer.java and passed.

JDK8 with this fix passes jdk_security4 at a local run (Mac OS) like JDK11.

JDK8 internal Grinder Build_JDK8_s390x_linux_Personal/535 passed jdk_security4 as well.

@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 16, 2021
Merged
@JasonFengJ9
Copy link
Member Author

I think this need go to v0.24.0-release, created #11670.

@JasonFengJ9 JasonFengJ9 deleted the setdc branch January 16, 2021 00:53
@mikezhang1234567890 mikezhang1234567890 mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdk_security4 test failed with credential exception because server returned HTTP response code 401
2 participants
@JasonFengJ9 @pshipton